Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ankr's Public RPCs #117

Open
Dhaiwat10 opened this issue Aug 9, 2022 · 2 comments · May be fixed by #128
Open

Add Ankr's Public RPCs #117

Dhaiwat10 opened this issue Aug 9, 2022 · 2 comments · May be fixed by #128
Labels
good first issue Good for newcomers

Comments

@Dhaiwat10
Copy link

Hi! Dhaiwat from Ankr here. First of all, I'm a fan of these templates. Thanks for maintaining them!

I saw that there could be some value added to these templates by adding Ankr's Free Public RPCs. They're free, don't require sign-ups and serve millions of requests every day reliably.

I think it would make a lot of sense to add these public RPCs to the readme and the hardhat config as fallbacks or defaults. Do you want me to go ahead and create a PR for that? Lmk what you think, thanks! :)
@andrejrakic andrejrakic added the needs votes Vote on this issue or feature with a thumbsup or down emoji label Aug 13, 2022
@andrejrakic
Copy link
Contributor

Hi @Dhaiwat10, thanks for raising this issue, such a cool idea, I love it! If you can open a PR to add it as fallbacks in the hardhat config that would be awesome. I would leave README as is however. Thanks!

@andrejrakic andrejrakic added good first issue Good for newcomers and removed needs votes Vote on this issue or feature with a thumbsup or down emoji labels Aug 22, 2022
@Dhaiwat10
Copy link
Author

@andrejrakic thanks! Will follow up with a PR :)

@Dhaiwat10 Dhaiwat10 linked a pull request Aug 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Ankr RPCs as fallback Dhaiwat10/hardhat-starter-kit
2 participants
@andrejrakic @Dhaiwat10