You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To give our source adapters higher type safety we should ensure that every Axios request gives a typed response.
An example of adding this can be seen in this PR: #1239
For each endpoint:
Add a ResponseSchema interface containing the structure of the API response. If integration tests are finished for the EA it should be easy to pull from there.
Consume it in the HTTP call by passing this interface as a generic
To give our source adapters higher type safety we should ensure that every Axios request gives a typed response.
An example of adding this can be seen in this PR:
#1239
For each endpoint:
ResponseSchema
interface containing the structure of the API response. If integration tests are finished for the EA it should be easy to pull from there.result
to its own variable instead of modifying the response data.Requester.withResult
utility to merge theresult
into the response data while maintaining types:The end goal is to be able to turn on the "noAny" and "noImplicitAny" settings in TypeScript across the whole mono-repo.
Acceptance criteria:
Granular tracking on the tracking sheet (shared privately)
The text was updated successfully, but these errors were encountered: