Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign In Form Input & Auto Fill #960

Closed
NavyAdmiral opened this issue Feb 5, 2019 · 7 comments
Closed

Sign In Form Input & Auto Fill #960

NavyAdmiral opened this issue Feb 5, 2019 · 7 comments

Comments

@NavyAdmiral
Copy link
Contributor

NavyAdmiral commented Feb 5, 2019

Was taking a look at the recent changes and there's this cheese in the form w auto-fill enabled (chrome):
image

I believe adding InputLabelProps={{ shrink: true }} for both inputs in https://github.com/smartcontractkit/chainlink/blob/master/gui/src/containers/SignIn.js#L98 and https://github.com/smartcontractkit/chainlink/blob/master/gui/src/containers/SignIn.js#L112 will fix the issue

cc @rupurt

@rupurt
Copy link
Contributor

rupurt commented Feb 13, 2019

@NavyAdmiral what OS are you using? I don't see this in Chrome or FF on OS X.

Also, what is doing the autofill? Is it coming straight from Chrome or are you using a password manager like 1Password or Dashlane?

@NavyAdmiral
Copy link
Contributor Author

NavyAdmiral commented Feb 13, 2019

That is chrome's auto-fill for passwords and it's on Windows. To reproduce it you have to open CL in a new tab (refreshing doesn't cheese it). I'll get you a gif asap

@NavyAdmiral
Copy link
Contributor Author

@rupurt
Copy link
Contributor

rupurt commented Feb 14, 2019

@NavyAdmiral cool. Time to fire up the VM

@NavyAdmiral
Copy link
Contributor Author

@rupurt mui/material-ui#718 goes back to 2015 😓

@steeply
Copy link

steeply commented Mar 4, 2019

I have the same problem

@NavyAdmiral
Copy link
Contributor Author

Closing as this is a browser issue mui/material-ui#14427 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants