Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try improve code for configuration value references #127

Open
vajda opened this issue Jun 5, 2017 · 0 comments
Open

Try improve code for configuration value references #127

vajda opened this issue Jun 5, 2017 · 0 comments

Comments

@vajda
Copy link

vajda commented Jun 5, 2017

Currently, configuration support value references, for example:

user:
  firstName: Nick
  lastName: Smith
someField: $user.firstName

This feature is useful, but code implementing it can be improved. Both ValueExpressionParser and DataGenerator classes have same private method stripOffLastReference and logic for constructing full name and usage of '.' character is spread through these two classes. This should probably be moved into separate class which both classes would use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant