Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reauthorization does not work beyond the first attempt #112

Open
timharsch opened this issue Jan 3, 2022 · 4 comments
Open

Reauthorization does not work beyond the first attempt #112

timharsch opened this issue Jan 3, 2022 · 4 comments

Comments

@timharsch
Copy link
Contributor

When using this library to download a large number of documents/resources from Cerner sandbox, it became apparent that reauthorization fails for all but the first attempt. This is because the refresh_token is lost when process the response from the remote host. In Cerner's case, it does not return the refresh token in the response, and so the token is erased from the server instance referenced by client.server

In our case we only use the DSTU2 version of client-py and I don't see anything in the CONTRIBUTING.md document about how to target PRs, so I'll just leave my solution here (which is a commit added on top on the v1.0.6 tag)
Unite-Genomics@c4f02e9

@ducu
Copy link
Collaborator

ducu commented Aug 27, 2022

Hi @timharsch, pull requests are welcome, let me know if still interested

@timharsch
Copy link
Contributor Author

PR created

@timharsch
Copy link
Contributor Author

Will be opening a new PR soon that applies the fix to the master branch.

@timharsch
Copy link
Contributor Author

Hi @ducu , the new PR is ready. Can you merge please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants