Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for creating PKCS12 with modern encryption #947

Open
pkininja opened this issue May 25, 2023 · 2 comments
Open

Support for creating PKCS12 with modern encryption #947

pkininja opened this issue May 25, 2023 · 2 comments
Labels
enhancement needs triage Waiting for discussion / prioritization by team
Milestone

Comments

@pkininja
Copy link

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

The "step certificate p12" command creates pcks12 files encrypted with RC2-40-CBC. This is outdated and insecure encryption. There does not appear to be a way to select different encryption.

Modern versions of OpenSSL will not open the file unless the "-legacy" flag is appended. The default encryption there for PKCS12 files appears to be AES-256-CBC with PBKDF2 algorithm.

I don't think this is a "vulnerability" in the step cli per se. The issue is in the files the step cli creates.

Tested on Windows 10 with
Smallstep CLI/0.23.4 (windows/amd64)
Release Date: 2023-0310T00:007:02Z

Why is this needed?

The step cli is a great modern utility, it should create files up-to-date with modern standards.

@pkininja pkininja added enhancement needs triage Waiting for discussion / prioritization by team labels May 25, 2023
@maraino
Copy link
Collaborator

maraino commented May 26, 2023

For context, it doesn't look like software.sslmate.com/src/go-pkcs12 supports encrypting PKCS#12 files using AES-256-CBC.

@hslatman
Copy link
Member

hslatman commented May 30, 2023

@maraino a PR was opened adding support for exactly this: SSLMate/go-pkcs12#47, which builds on SSLMate/go-pkcs12#39.

@maraino maraino added this to the Backlog milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

No branches or pull requests

3 participants