Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid infinite loop in slime-presentation-start/end #815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid infinite loop in slime-presentation-start/end #815

wants to merge 1 commit into from

Conversation

corngood
Copy link

@corngood corngood commented Mar 2, 2024

Fixes #814

This doesn't fix the underlying problem, which is that company-mode copies parts of buffers that contain:

      (add-text-properties start end
                           `(modification-hooks (slime-after-change-function)
                             insert-in-front-hooks (slime-after-change-function)
                             insert-behind-hooks (slime-after-change-function)
                             syntax-table ,slime-presentation-syntax-table
                             rear-nonsticky t))

And then slime-after-change-function gets run on them. Should slime-after-change-function be more defensive about where it's called from?

@stassats
Copy link
Member

stassats commented Mar 2, 2024

I would rather merge a proper solution.

@corngood corngood mentioned this pull request Mar 2, 2024
Merged
@corngood
Copy link
Author

corngood commented Mar 2, 2024

company-mode/company-mode#1460

Is my fix for the problem in company-mode.

I still think this is a good change, because it should be able to reliably avoid an infinite loop, which can be triggered by other packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite loop in slime-presentation-start
2 participants
@corngood @stassats