Warning: 'etypecase' is an obsolte alias (as of 27.1)

[gendl]

Hi,

This is related to the closed #48.

Ever since upgrading my copilot.el a few days ago, if we load copilot.el as follows after having Slime loaded:

(setq copilot-node-executable "node")
(use-package copilot :straight (:host github :repo "zerolfx/copilot.el" :files ("dist" "copilot.el")) :ensure t)

Then we get warnings such as this:

.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘ecase’ is an obsolete alias (as of 27.1); use ‘cl-ecase’ instead.
.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘destructuring-bind’ is an obsolete alias (as of 27.1); use ‘cl-destructuring-bind’ instead. [2 times]
.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘destructuring-bind’ is an obsolete alias (as of 27.1); use ‘cl-destructuring-bind’ instead.
.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘etypecase’ is an obsolete alias (as of 27.1); use ‘cl-etypecase’ instead.
.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘assert’ is an obsolete alias (as of 27.1); use ‘cl-assert’ instead.
.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘etypecase’ is an obsolete alias (as of 27.1); use ‘cl-etypecase’ instead.
.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘assert’ is an obsolete alias (as of 27.1); use ‘cl-assert’ instead. [2 times]
.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘ecase’ is an obsolete alias (as of 27.1); use ‘cl-ecase’ instead.
.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘assert’ is an obsolete alias (as of 27.1); use ‘cl-assert’ instead. [3 times]
.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘etypecase’ is an obsolete alias (as of 27.1); use ‘cl-etypecase’ instead.
.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead.
.config/dot-files/crafted-emacs/sideloaded/slime-v2.28/lib/ert.el: Warning: ‘ecase’ is an obsolete alias (as of 27.1); use ‘cl-ecase’ instead.

And, this creates further problems downstream.

Somehow copilot is trying to load or require ert, and for some reason it's picking up the ert in lib/ of slime.

The only way I've found to eliminate the problem is to eliminate those two files, ert.el and ert-x.el, from Slime's lib/ directory.

This may be more copilot.el's bug than Slimes, I'm not sure. But would anyone be able to see what is going on here?

Thanks,

Dave

[luismbo]

slime-tests.el suggests that we bundle ERT in for Emacs 23 which I don't think we support anymore. Can you send a PR removing it?

I think lib/ert.el is already being ignored in the melpa recipe, so I'm guessing that's not how you got your copy of slime right? https://github.com/melpa/melpa/blob/master/recipes/slime