Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename isBmpLast, used for Unicode data #176

Open
slevithan opened this issue Apr 17, 2017 · 1 comment
Open

Rename isBmpLast, used for Unicode data #176

slevithan opened this issue Apr 17, 2017 · 1 comment
Labels

Comments

@slevithan
Copy link
Owner

In the Unicode data generators (under tools/) and Unicode addons, rename isBmpLast as the more descriptive hasOrphanHighSurrogatesAndAstral. It's only used for category C and property Any, so the long name doesn't matter.

  • Or just hasOrphanHighSurrogates and let Unicode Base know to also check whether there is astral data before flipping the order of bmp and astral data.
  • Or just hasOrphanSurrogates and let Unicode Base know to also check whether there is astral data before flipping the order. This would mean attaching this prop in more cases where it isn’t currently useful (either because there’s no astral data or there are only low surrogates), but that’s probably not so bad.
@slevithan
Copy link
Owner Author

I don't think this should be treated as a breaking change, since isBmpLast is unlikely to be used by any existing addons outside of the official XRegExp Unicode addons (which themselves barely use it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant