Navigation triggered multiple times on fast taps

[ateslovan]

Hello!

I've been playing around with the library for a while and I'm curious if anyone else stumbled upon this issue. Whenever I trigger a navigation event based on a click event, if I press the element in question super quickly the navigation might be triggered multiple times. For example, in the tutorial sample - if I press the avatar of the user twice super fast the DetailsScreen will be opened twice. Is this working as intended and up for us to handle?

[ZacSweers]

Yeah this is a classic debouncing situation. I thought about it early on, but I feel like this should be handled at the UI level. Maybe there's something more we can do in NavigableCircuitContent today, but nothing springs to mind. We would need for some way for NavigableCircuitContent to indicate back to the navigator that it has "completed" the push, so to speak. Maybe @stagg or @chrisbanes have alternative ideas.

[chrisbanes]

A quick way to handle this would be to check the current back stack 'top record', and no-op if it's the same. Something like this:

fun Navigator.goToScreen(screen: Screen, skipIfSame: Boolean = true) {
  if (skipIfSame && peek() == screen) return
  goTo(screen)
}

[ateslovan]

A quick way to handle this would be to check the current back stack 'top record', and no-op if it's the same. Something like this:

fun Navigator.goToScreen(screen: Screen, skipIfSame: Boolean = true) {
  if (skipIfSame && peek() == screen) return
  goTo(screen)
}

I had considered something along those lines, but initially, I was thinking of incorporating a custom Navigator. This solution is more straightforward. Since it's so simple, I'm unsure whether it's worth incorporating into the library or perhaps just providing a heads-up in the documentation 🤔

[ZacSweers]

I think this'll functionally be covered by #1331 in the next release