Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTM message format has changed, verify eventWrapper assumptions #589

Open
4 of 6 tasks
aoberoi opened this issue Apr 2, 2020 · 2 comments
Open
4 of 6 tasks

RTM message format has changed, verify eventWrapper assumptions #589

aoberoi opened this issue Apr 2, 2020 · 2 comments
Labels
enhancement M-T: A feature request for new functionality

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Apr 2, 2020

Description

We've noticed some changes in the RTM message format but have not actively updated the processing of each event in eventWrapper accordingly. It's possible that some of the assumptions made are no longer valid. That was the case in #586 - since bot_message events started having a user property the logic behind when to update the botUserIdMap was no longer correct.

A few more things to check:

  • Do we still need a botUserIdMap? I think yes, because the user ID of the bot is not enough information to put in the message.user object, otherwise there will be breaking changes. However, we also see a bot_profile on some (maybe all) events now - is that enough?
  • What happened to the subtype: 'bot_message'? It seems to be missing on at least some, but maybe all, events where it should be.
  • Is there a new property that can be used to know that a message was sent from Slackbot?

This is not an exhaustive list, and we should look for more changes we may need to make to eventWrapper.

Related to #588

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added the enhancement M-T: A feature request for new functionality label Apr 2, 2020
@seratch
Copy link
Member

seratch commented Apr 2, 2020

Do we still need a botUserIdMap? I think yes, because the user ID of the bot is not enough information to put in the message.user object, otherwise there will be breaking changes.

I also think - yes, we do. The cache is necessary to provide full information about bot users.

However, we also see a bot_profile on some (maybe all) events now - is that enough?

This may be also true. That said, for the forthcoming patch releases, I don't want to introduce any breaking changes.

If we all are on the same page regarding this, we can safely merge my PR #588 and release a new patch version to address #586 .

@github-actions
Copy link

github-actions bot commented Dec 5, 2021

👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

No branches or pull requests

2 participants