Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby 2.7.1 picky throwing deprecation warning #334

Open
sonjz opened this issue Jul 2, 2020 · 4 comments
Open

ruby 2.7.1 picky throwing deprecation warning #334

sonjz opened this issue Jul 2, 2020 · 4 comments
Labels

Comments

@sonjz
Copy link

sonjz commented Jul 2, 2020

Noticed this deprecation warning on picky which I've loaded to use the search function.

/Users/user/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/picky-4.31.3/lib/picky/index.rb:128: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
(__FORWARDING__):1: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/user/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/picky-4.31.3/lib/picky/category_realtime.rb:14: warning: The called method `add' is defined here

there is a PR on picky, but hasn't been worked on for 5 years.
floere/picky#150 (review)

@dblock dblock added the bug? label Jul 2, 2020
@dblock
Copy link
Collaborator

dblock commented Jul 2, 2020

If you/someone wants to investigate, find out what brings picky in, we don't have any direct dependencies on it.

@sonjz
Copy link
Author

sonjz commented Jul 7, 2020

@dblock no worries PR in the works by picky, will verify and come back to close floere/picky#150 (comment)

@sonjz
Copy link
Author

sonjz commented Oct 26, 2021

floere doesn't appear to be updating the package, and i tried a patch and it didn't work.

any thoughts on deprecating Picky for something else?

I'd like to use it for user_search.

@dblock
Copy link
Collaborator

dblock commented Oct 28, 2021

Gladly will take PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants