Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] AWS: deprovision --all does not deprovision all resources in AWS #921

Open
jpo-tu opened this issue Sep 13, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@jpo-tu
Copy link

jpo-tu commented Sep 13, 2023

Describe the bug
The deprovision --all command does not deprovision all resources in AWS.

To Reproduce

  1. initiate a copy or sync from any cloud provider to AWS; this provisions a VPC and ancillary resources in AWS
  2. deprovision everything:
    skyplane deprovision --all

Expected behavior
All resources created by skyplane in AWS - that is, EC2 instances, instance profiles, security groups, route table associations, VPC endpoints, nacls, subnets, internet gateways, VPCs - should be deleted.

Actual behavior
Only EC2 instance profiles are deleted. EC2 instances themselves are typically already terminated at the end of a copy/sync.

Output:

root@28e526f36e9b:/workdir# skyplane deprovision --all
No instances to deprovision
✓ Removing IPs from VPCs (1/1) in 1.95s
Deleting firewall rule: allow-default-4db23ad1
Deleting firewall rule: allow-default-9bb0b9df
Deleting firewall rule: skyplane-default-allow-icmp
Deleting firewall rule: skyplane-default-allow-internal
Deleting firewall rule: skyplane-default-allow-ssh

Environment info:

  • OS: Debian GNU/Linux 11 (bullseye)
  • Python version 3.9.2
  • Skyplane version 0.3.2

Additional context
Why isn't delete_vpc invoked when deprovisioning in AWS?

@jpo-tu jpo-tu added the bug Something isn't working label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant