Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stoke color to Balloon and Arrow #38

Open
JohnGeorgiou opened this issue Apr 14, 2020 · 8 comments
Open

Stoke color to Balloon and Arrow #38

JohnGeorgiou opened this issue Apr 14, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@JohnGeorgiou
Copy link

Hi , and thanks for thiis useful library,
I try to create a simple balloon with white background , arrow, and black stroke color.
Is it possible to have a stroke outline to balloon?
Alternatively, is it possible to create a shadow to simulate a stroke?

thanks in advance

@skydoves
Copy link
Owner

Hi, I was thinking about this issue for a few days, but there is no clear way to resolve this issue.
Because of the body of the balloon and the arrow is actually separated each other.
Thank you for your issue :)

@JohnGeorgiou
Copy link
Author

JohnGeorgiou commented Apr 18, 2020

Yes I see,
the two items have the same background, the only thing you have to do is to add a line with the background color over the arrow,
I could add a commit, but unfortunately Im a Java person

@skydoves
Copy link
Owner

Making a stroke on a balloon (except the bottom, only oblique sides) is an easy problem.
But we should remove the little line against the position of the arrow on the balloon body.
If not there will be a boundary between the arrow and the balloon body.

@JohnGeorgiou
Copy link
Author

Look at the attached drawing to see what I mean
balloon

@skydoves skydoves added the enhancement New feature or request label May 12, 2020
@znakeeye
Copy link

Why not use a clipping rectangle (the balloon) for the arrow?

The suggested hack is not desirable.

@XLAR-8
Copy link

XLAR-8 commented Jun 29, 2021

Hey @skydoves, great work with the lib.
are we expecting this feature anytime soon?
is there a way to set alpha to arrow too (below code gives color difference in balloon and arrow)?
and how to set border highlight(strokes) at present?

class BalloonFactory : Balloon.Factory() {
    override fun create(
        context: Context,
        lifecycle: LifecycleOwner?
    ): Balloon = createBalloon(context) {
        setArrowSize(17)
        setHeight(45)
        setWidth(160)
        setAlpha(0.8f)
        setArrowColorResource(R.color.trans_secondary_80)
        setCornerRadius(4f)
        setPadding(4)
        setTextResource(R.string.series_state_complete_msg)
        setTextSize(TEXT_SIZE.toFloat())
        setTextColorResource(R.color.fefefe)
        setBackgroundColorResource(R.color.black_04pc)
        setLifecycleOwner(lifecycleOwner)
        arrowOrientation = ArrowOrientation.LEFT
        build()
    }
}

@emretanerc
Copy link

Any progress? We have difficulty reading because the balloon is opened on a white background. We want to change the border color.

@rezafaraji93
Copy link

We are also looking for this change. the border of balloon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants