Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BigNumber in all code related to coin and coin hours amounts #2527

Open
iketheadore opened this issue Nov 13, 2020 · 3 comments
Open

Use BigNumber in all code related to coin and coin hours amounts #2527

iketheadore opened this issue Nov 13, 2020 · 3 comments
Projects
Wallet GUI

Comments

@iketheadore
Copy link
Member

Senyoret1 commented on Dec 18, 2019

To ensure the wallet works well in edge cases, all code related to coin a coin hours amounts should use the BigNumber class.
@iketheadore iketheadore added this to To do in Wallet GUI via automation Nov 13, 2020
@iketheadore
Copy link
Member Author

@Senyoret1 is this fixed?

@Senyoret1
Copy link
Contributor

This should have been fixed in #2589 , but an in-deep code review would be needed to be 100% sure. However, I think no relevant problems should remain at this moment.

@iketheadore
Copy link
Member Author

okay, thanks. Please let me know when you are sure about it, I'll close this issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Wallet GUI
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iketheadore @Senyoret1