Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to async logging? #23

Open
aecay opened this issue Jul 22, 2019 · 2 comments
Open

switch to async logging? #23

aecay opened this issue Jul 22, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@aecay
Copy link
Collaborator

aecay commented Jul 22, 2019

Currently mite uses blocking calls to the logging library to do its logging. Unfortunately, python doesn't have async logging built in. We could switch to https://github.com/B2W-BIT/aiologger for our logging. The advantage of doing so is that the log calls will be asynchronous, and play with the io model that mite uses. But it presupposes an additional dependency.

@aecay aecay added brainstorming conceptual issue, which may or may not need concrete code changes enhancement New feature or request and removed brainstorming conceptual issue, which may or may not need concrete code changes labels Aug 15, 2019
@jb098
Copy link
Collaborator

jb098 commented Nov 13, 2019

Another fat friday task @aecay @DavAnnunz @arroncanhamskyuk, be good to do a spike and look whether it gives us a worthwhile perf boost.

@aecay
Copy link
Collaborator Author

aecay commented Nov 13, 2019

👍 for a fat friday. I think this should be deferred until after the perf test suite is merged, just to make it easier to measure the impact of the change. I hope to get back to that soon, because it's (sort of) one of my PDP goals (I think I technically just committed to integration testing, not full perf tests, but one is a stepping stone to the other).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants