Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating config while tests run #13

Open
aecay opened this issue Jun 28, 2019 · 2 comments
Open

Updating config while tests run #13

aecay opened this issue Jun 28, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@aecay
Copy link
Collaborator

aecay commented Jun 28, 2019

Mite has the ability to propagate changes in the ConfigManager to runners after the initial setup. In each call to Controller.request_work, a dictionary diff is computed (via ConfigManager.get_changes_for_runner) and sent over the wire; this is unpacked in the runner.

But as far as I can tell, this feature is never used. The only call to ConfigManager.set in the mite code is in __main__._create_config_manager (which is called at startup). I could not find any calls either in the id-mite-nft data repo.

@aecay aecay changed the title Do we need the ability to synchronize config across runners beyond initial startup? Updating config while tests run Jul 9, 2019
@aecay
Copy link
Collaborator Author

aecay commented Jul 9, 2019

From @jb098 in #15:

It would obviously need some thought about how we wanted a live config to operate. Either providing a zmq admin channel, a http endpoint or have it refresh from env vars at regular intervals.

@aecay aecay added the enhancement New feature or request label Jul 9, 2019
@aecay
Copy link
Collaborator Author

aecay commented Jul 9, 2019

We might want to implement a new message type for this, rather than passing a (almost always empty) dict of config changes on every communication from the controller to the runner.

@aecay aecay mentioned this issue Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant