skpm publish swallows prompt for passphrase when git pushing

[sigtm]

I've had no trouble publishing before, but suddenly it's not working. I've logged in with a GitHub access token like before (did a factory reset since so it had to be regenerated), which skpm told me was successful. The usual "Publish 2.0.1 release" and "Update .appcast ..." commits appear in my local branch in SourceTree, but in Terminal it's just stuck on "Pushing the changes to Github".

Under releases I can see what looks like an unfinished 2.0.1 release? And the update appears in Sketch 50 with a notification, but pressing "Update" in the plugin list has no effect. Here's my releases as they look now:

https://github.com/sigtm/sketch-style-libraries/releases

Any idea why this might be happening? A bit desperate to get this fix out, since my plugin won't work in Sketch 50 until I do :/

[sigtm]

Note: I just fixed the 2.0.1 release myself manually to get it out. For reference, before I did that it looked like 2.0.1 was just a draft/tag? And with no zip file attached. I'm not used to dealing with releases, but I added a zip of the plugin file myself and published the release, which seemed to fix it so it updates in Sketch. But I suspect the problem would still persist if I tried to publish another version through skpm, since it happened several times in a row.

[mathieudutour]

so the push succeeded but skpm didn't notice it? What version of skpm are you using?

as for the "unfinished release", it's just how a tag looks like without release attached to it.

[sigtm]

@mathieudutour: No it seemed to just commit the new package.json version number and appcast tag to my local branch, but it never got pushed to GitHub. I had to ctrl+c to terminate the process, and then pushed manually with SourceTree. Then I had to manually zip my plugin file and upload it to the 2.0.1 tag and publish it.

Anything I can do to help troubleshoot it? If there's a flag I can use to output more detailed information I can try that with another version to see if it happens again.

[sigtm]

Ah, I found out what was causing it: my SSH key in ~/.ssh/id_rsa requires a passphrase, and skpm doesn't let me enter it when it attempts to git push origin HEAD – instead it just gets stuck with the spinner stuck on "Pushing the changes to Github". I added my passphrase to the keychain now so it gets past it.

Don't know if storing it in the keychain is problematic enough to anyone to warrant a proper fix. But I did notice I'm not the first person over at sketchplugins.com to run into this, so maybe the quickest fix is just to clarify this in Readme 😄

[mathieudutour]

ah! I'm wondering if we can fix this 🤔
Does it print something when you are being asked the passphrase?

[sigtm]

No it just says Pushing the changes to GitHub with the spinner animation still going

[mathieudutour]

no I mean when you do git push origin HEAD yourself?

[sigtm]

Oh sorry yeah I don't remember the exact wording now, but it says something like Enter passphrase for key xyz: if I remember correctly? I can try removing it from my keychain tomorrow to take a screengrab if it helps – just leaving the office for the day or I'd do it now.

[mathieudutour]

no worry. I'm just wondering if we can recognize that and forward it to the user instead of just handing