Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin broken by latest Lektor #6

Open
dairiki opened this issue May 9, 2023 · 1 comment
Open

Plugin broken by latest Lektor #6

dairiki opened this issue May 9, 2023 · 1 comment

Comments

@dairiki
Copy link

dairiki commented May 9, 2023

The Lektor PRs lektor/lektor#1104 (already merged to master) switches from using ImageMagick to using Pillow for thumbnail generation. (PR lektor/lektor#1138 is continuing work on that new code.) At this point, the new code is only in the pre-release branch. Install Lektor>=3.4.0b6 to try it out.

I'm fairly certain that has broken this plugin. Um, Is that a problem?

The primary issue is that, since Lektor no longer uses ImageMagick, find_imagemagick and build_state.config["IMAGEMAGICK_EXECUTABLE"] are gone. (compute_dimensions and get_quality are gone too, but they can easily be put back for the sake of backward-compatibility.)

If there's something we can do on the Lektor side to help, let me know.

@skorokithakis
Copy link
Owner

Hm, I imagine it is a problem, but I personally have just frozen the version of Lektor that I use to generate my site and solved the problem that way :P If someone wants to use the plugin with the newer versions and it doesn't work, I'd be happy to accept a PR to fix it.

I don't think it'll need any changes on the Lektor side. If anything, using Pillow's functions will be much easier than calling out to ImageMagick, so that bit should be ok. Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants