Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputItem::offset returntype #624

Open
Reviewmaximizer2022 opened this issue Nov 10, 2022 · 5 comments
Open

InputItem::offset returntype #624

Reviewmaximizer2022 opened this issue Nov 10, 2022 · 5 comments

Comments

@Reviewmaximizer2022
Copy link

Deprecated: Return type of Pecee\Http\Input\InputItem::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Fix:
Add the #[\ReturnTypeWillChange] attribute to the offsetGet method or add return type to be bool|null

@Reviewmaximizer2022 Reviewmaximizer2022 changed the title InputIte::offset returntype InputItem::offset returntype Nov 10, 2022
@DeveloperMarius
Copy link
Contributor

Hey,

this project is currently not supported for php 8.
My fork has a php 8.1 branch.

Warning: There are a lot of undocumented breaking changes to the InputHandler. I hope to document it in the comming weeks.

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/developermarius/simple-php-router"
        },
        {
            "type": "composer",
            "url": "https://packagist.org"
        }
],
"require": {
  "pecee/simple-router": "dev-v5-development-php8"
}

~ Marius

@Mcgurk-Adam
Copy link

Is this a repo that's currently open to new contributors? I would love to make a contribution and get it out. For basic users like myself, this is the only blocker to using php8, but it is a major one. @skipperbent @DeveloperMarius . I'm happy to make a PR or even take on a larger role in the repo. This is a great repo that I would hate to see die.

@DeveloperMarius
Copy link
Contributor

Hey,
my repo is always open for contribution and is php 8.1 compatible. Feel free to create a PR.

~ Marius

@skipperbent
Copy link
Owner

Is this a repo that's currently open to new contributors? I would love to make a contribution and get it out. For basic users like myself, this is the only blocker to using php8, but it is a major one. @skipperbent @DeveloperMarius . I'm happy to make a PR or even take on a larger role in the repo. This is a great repo that I would hate to see die.

@Mcgurk-Adam , @DeveloperMarius If you can point me in the direction on how to create a maintainer i would be more than happy to give you guys the role. Do I have to create a team first?

@DeveloperMarius
Copy link
Contributor

Hey @skipperbent ,

Try collaborators in the settings of the repo. But I am not quite sure myself.

~ Marius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants