Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestBody.asMultipart has the bug that puts the end boundary of multipart/form-data to the wrong location. #378

Open
Pinchan opened this issue May 28, 2018 · 0 comments

Comments

@Pinchan
Copy link

Pinchan commented May 28, 2018

RequestBody.asMultipart has the bug that puts the end boundary of multipart/form-data to the wrong location.
This method should put the end boundary to outside of request.multipartFormData.foreach in RequestBody.asMultipart .

http-client/src/main/scala/skinny/http/RequestBody.scala

As Is

--XXX
Content-Disposition: form-data; name="abcde"

abcde
--XXX--
--XXX
Content-Disposition: form-data; name="abcde"

abcde
--XXX--

To Be

--XXX
Content-Disposition: form-data; name="abcde"

abcde
--XXX
Content-Disposition: form-data; name="abcde"

abcde
--XXX--
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant