New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make $if's nicer #121

Open

Alexey-T opened this issue Jun 19, 2022 · 0 comments

Alexey-T commented Jun 19, 2022 •

edited

https://github.com/skia4delphi/skia4delphi/blob/main/Source/VCL/Skia.Vcl.pas
has many $if defines

{$IF CompilerVersion < 33}

and

{$IF CompilerVersion >= 32}

Better make the IFDEF at the top for all these IF's: like

  {$IF CompilerVersion < 33}
    {$define NameOfTheCompilerFeature}
  {$endif}

This way it will be better portable to e.g. lazarus.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment