-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elfeed-show-refresh--mail-style base URL is incorrect for kottke.org #476
Comments
One potential concern that I have is that link URLs could theoretically pointing anywhere, not just at the site I originally configured. It would be nice to lock that down more tightly somehow. Perhaps having an |
I looked at this a bit more today. I was thinking of changing I'm an elfeed-org user as well so if this change would be acceptable I'll also submit a PR to elfeed-org to allow feed metadata to be specified, probably using a property on the feed entries. |
Given the proposed commit I made hasn't had an enthusiastic reception I've resorted to solving this a different way for now. I used
For the problem reporting here I'm setting
I still think my proposed patch is a more elegant solution for this problem, but this works around the problem until there is an upstream fix without me having to maintain my fork. |
I subscribe to the RSS feed of kottke.org at https://feeds.kottke.org/main. However, all the article links are at https://kottke.org/. The
elfeed-show-refresh--mail-style
function computes thebase
URL that it uses to insert HTML into theelfeed-show
buffer from thefeed
URL. As a result images in the article with relative paths fail to render because they are pulled fromhttps://feeds.kottke.org/<image path>
instead ofhttps://kottke.org/<image path>
.I have worked around the problem by temporarily redefining that function to use the link URL instead of the feed URL. This fixes the problem for kottke.org and I haven't noticed any other problems for other feeds yet. However, I'm unsure whether there are potential issues that I haven't run into yet.
The text was updated successfully, but these errors were encountered: