Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@skatejs/element-react "Invalid component name" error on WebComponent disconnectedCallback #1566

Open
Valdermeyder opened this issue Jun 26, 2019 · 0 comments

Comments

@Valdermeyder
Copy link

Bug report

"ReactDOM.render(): Invalid component element" is shown in console when a component is removed from the DOM

The error comes from packages/element-react/src/index.ts line 11

render(null, this.renderRoot);

Is there any reason to have the line here in case React consider null as an invalid component?

  • Skate version:
    • @skatejs/define: 0.0.1
    • @skatejs/element-react: 0.0.1
  • ReactDOM version: 15.6.2
  • Affected browsers (and versions): every

Current behaviour

Error in console

Expected behaviour

No error in console when WebComponent is removed from the DOM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant