Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call super.observedAttributes #1389

Open
treshugart opened this issue Feb 20, 2018 · 3 comments
Open

Call super.observedAttributes #1389

treshugart opened this issue Feb 20, 2018 · 3 comments

Comments

@treshugart
Copy link
Member

This is for two reasons:

  • We should mix in any observedAttributes from the parent.
  • This is a perfect integration point for one-time setup upon definition and other mixins might use it.
@treshugart treshugart mentioned this issue Feb 20, 2018
Merged
chrisdarroch added a commit to chrisdarroch/skatejs that referenced this issue Feb 24, 2018
@chrisdarroch
feat: withUpdate() and withComponent() incorporate observed attribute…
7451951 
…s from superclass (skatejs#1389)
@chrisdarroch
Copy link
Contributor

I've addressed this in #1397 :)

@treshugart
Copy link
Member Author

Nice, @chrisdarroch, thanks! I've just reviewed that. Looking for some feedback.

@treshugart
Copy link
Member Author

treshugart commented May 27, 2019 •
edited

This isn't being done in @skatejs/element anymore, but probably should be.

@treshugart treshugart changed the title withComponent() should call super.observedAttributes Call super.observedAttributes May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisdarroch @treshugart