Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangs on error conditions #54

Open
mars opened this issue Dec 13, 2017 · 1 comment
Open

Hangs on error conditions #54

mars opened this issue Dec 13, 2017 · 1 comment

Comments

@mars
Copy link

mars commented Dec 13, 2017

First of all, thank you for creating a Node module that performs this very special task and for sharing it with us!

I've found two different conditions that cause the host program to hang indefinitely (in Node 8.9.0), never reporting an error or any hint of what the issue could be. I debugged these problems through a couple of arduous debug sessions:

  1. Writing data arrays that contain null/undefined instead of empty Array indexes for optional fields.
    What is an empty Array index? How does one create an empty Array index? The answer is that it is impossible to explicitly create an empty index. Instead, you have to create an empty Array and then set only the indexes that should contain a value. The remaining indexes are "empty", a little-known aspect of JavaScript Arrays.
  2. Writing a parquet file to a directory that does not exist.

Each of these are not necessarily problems, especially if they're documented. The problem is that this module does not throw errors, instead it hangs.

@mars
Copy link
Author

mars commented Jul 6, 2018

Following-up on my 1. above,

Remy Sharp just published a fantastic post about this topic:
👓 An Adventure in Sparse Arrays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant