Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for Dark Mode #5

Closed
wants to merge 2 commits into from
Closed

Icons for Dark Mode #5

wants to merge 2 commits into from

Conversation

akaustav
Copy link

@akaustav akaustav commented Jun 27, 2020

Fixes #4

Developer Notes:

  • Followed steps from this SO question.
  • I am not sure how to build the extension, so have not tested if this actually works.
  • Missing icons:
    • src/chrome/img/24-default.png
    • src/chrome/img/32-default.png
    • src/chrome/img/48-light.png
    • src/chrome/img/128-light.png
  • I am not sure if "<all_urls>" permission needs to be moved from the "optional_permissions" array into the "permissions" array in src/chrome/manifest.json.

@sixcious
Copy link
Owner

This feature has been added (only on new installations) and you've been credited. Thanks for your help!

@sixcious sixcious closed this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark icon blends with background in Dark Mode
2 participants