Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit dialog is too wide with lots of empty spaces #313

Open
ghost opened this issue Nov 23, 2016 · 8 comments
Open

Edit dialog is too wide with lots of empty spaces #313

ghost opened this issue Nov 23, 2016 · 8 comments

Comments

@ghost
Copy link

ghost commented Nov 23, 2016

When you try to add an element, the UI covers the entire screen with lots of empty spaces.
For example look at this screenshot:

screen shot 2016-11-22 at 9 31 44 pm

there are empty spaces which could be removed by simply making the box smaller.

can we resize the edit box to be smaller?

@ghost
Copy link
Author

ghost commented Nov 24, 2016

What do you guys think about this?

screen shot 2016-11-24 at 1 19 54 am

screen shot 2016-11-24 at 1 21 52 am

Editor Example

screen shot 2016-11-24 at 1 28 24 am

100% width for inputs

we can also make the width for input fields 100% to keep the consistency

screen shot 2016-11-24 at 1 41 49 am

so instead of full screen, I just reduced the width of the dialog box to around 700px.
this removes all the empty spaces

what do you guys think?

@ghost ghost changed the title Edit box is too wide with lots of empty spaces Edit dialog is too wide with lots of empty spaces Nov 24, 2016
@ghost
Copy link
Author

ghost commented Nov 28, 2016

@AlexGStapleton any follow up with this?

@AlexGStapleton
Copy link
Member

AlexGStapleton commented Nov 29, 2016

Hi @littlehamster,

I'm unsure of the original idea behind making it that large but I suspect it related to the possible contents of the modal itself. There's currently no way (that I know) that will allow you to resize the modal without manually resizing it via admin_enqueue_scripts.

Regarding your suggestion, I'm not too sure I like it to be honest - it seems restrictive. A better solution would be to give widgets the ability to define the width rather than enforcing any one set width. This way if a widget required a slightly larger area for usability reasons, it can override the default.

With that said, I like the full-width fields in certain instances but I don't like them in others. There's little reason to have a measurement field look like that as there's no way the contents will require a field that big.

@ghost
Copy link
Author

ghost commented Dec 3, 2016

@AlexGStapleton
thanks for your feedback,

do you know any case where we need a dialog box that size for a widget? I tested the majority of the widgets in the bundle package and we have so much empty spaces in all of them. If you look at my first screenshot, do you think having that much empty space is reasonable?

also the full width fields has been widely used in other plugins UI, for example visual composer:

screen shot 2016-12-03 at 1 55 35 am

or Advanced Custom Field:

@AlexGStapleton
Copy link
Member

I'm unsure. Our Widgets Bundle is actually also a framework so any plugin can make use of it as a base. As such, restricting it to a certain size isn't something that should really be done as it may limit certain widgets. What widgets I don't know, but it would be better not to put an artificial limit in place regardless.

I'm okay with the idea of making the fields full width now.

I'm going to forward this thread to Greg.

@ghost
Copy link
Author

ghost commented Dec 3, 2016

@AlexGStapleton I am glad that you like the idea of full width fields. But it only works if we reduce the size of the dialog box, else, it would be a terrible idea. Imagine having full width in the first screenshot, I don't think user experience-wise it would work if we are not going to reduce the size of the dialog box.

In both examples where fields are full width, the dialog is small and not full screen.

@gregpriday
Copy link
Member

I agree that for certain widgets, the excess white space isn't all that attractive. The main reason we made the widget dialogs bigger was to give space for things like nested repeater fields with TinyMCE fields. In this case, the more horizontal space, the better.

One solution might be to add an extra button to the menu bar (next to the left and right navigation arrows), that allows the user to collapse the widget dialog into a narrower fixed-width.

@ghost
Copy link
Author

ghost commented Mar 26, 2017

@gregpriday yes, that is an option too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants