Incorrect error detection in SMTP connection

[SpeckiJ]

When sending an Email fails. e.g. due to issues with the credentials, a callback(err) is invoced instead of a correct callback(err, 500). Additionally it seems like err.message is not set by the transport library, instead an additional info object is provided.

Ethics-app/controllers/documents/post.js

Line 238 in de7f31e

callback(err);

This issue can happen because depending on the SMTP configuration, the verify function

Ethics-app/server.js

Line 61 in de7f31e

trans.verify(function(error, success) {

might succeed even though sending emails will be rejected later on.