Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you like to get some of the features from my fork? #729

Closed
5 tasks done
vslinko opened this issue May 12, 2024 · 3 comments
Closed
5 tasks done

Would you like to get some of the features from my fork? #729

vslinko opened this issue May 12, 2024 · 3 comments

Comments

@vslinko
Copy link
Contributor

vslinko commented May 12, 2024

I made some features for myself:

Maybe something might be interesting to merge into the original repo? I could make a fully functional PR with good UI, tests, etc.

@sissbruecker
Copy link
Owner

Thanks, those look useful. Some thoughts:

  • Auto tagging: Definitely a cool idea, though that could require a bit of effort to get right. For one there would need to be a proper UI for configuring the auto tags. Another thing is that you might want to see which tags will automatically get assigned when adding a bookmark through the form, and possibly through the extension. Not a blocker though.
  • Preview lazy loading: Makes sense, regarding implementation it should be possible to use the loading attribute on the image though: https://developer.mozilla.org/en-US/docs/Web/Performance/Lazy_loading#images_and_iframes
  • Disable tag grouping: It seems straightforward to implement and I can see that the alphabetical grouping doesn't work for everyone. I guess adding this as an option would be fine, though I'd structure it so that the setting would be a select where you can choose how to group tags. By default it's alphabetical, with a second option to just disable grouping. Then later on maybe more grouping types can be added.
  • Hide tooltip on mobile: Missing context here, what's the issue? If there's a UX problem, I'm fine with it getting fixed, though a bug issue with some context would help.
  • Pinned bookmarks: Maybe, I think that would require some more thought. Making pinned bookmarks always show up at the top would be super annoying for me, I'd prefer a filter or maybe even a separate view for viewing them. Another issue is the order in which pinned bookmarks are displayed. I think if there are pins, then it should be possible to define a custom order for those, so that adding a new pin does not interfere with the order that I have memorized. And if you have a lot of pins, then you might want to cluster them into categories. At that point you basically get close to a custom dashboard, which IMO is the most useful variant of this concept, but also the most complex one to implement. There's an existing issue for that so maybe continue the discussion there for now.

@vslinko
Copy link
Contributor Author

vslinko commented May 14, 2024

Preview lazy loading: Makes sense, regarding implementation it should be possible to use the loading attribute on the image though: https://developer.mozilla.org/en-US/docs/Web/Performance/Lazy_loading#images_and_iframes

I prefer JS implementation because Safari loads all the lazy images in the background. The lazy attribute just lowers the priority.

If there's a UX problem, I'm fine with it getting fixed, though a bug issue with some context would help

If you click on a link on mobile (I tried on iOS), then go back, the link will be in focus and the tooltip will overlap half of the link, which is annoying because it's hard to take the focus off on mobile.

@vslinko
Copy link
Contributor Author

vslinko commented May 14, 2024

Thanks for the feedback, I'll think about how to make good PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants