Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional markdown descriptions #717

Open
bloodripelives opened this issue Apr 22, 2024 · 1 comment
Open

Optional markdown descriptions #717

bloodripelives opened this issue Apr 22, 2024 · 1 comment

Comments

@bloodripelives
Copy link

Related to #709, I imported bookmarks from Shaarli which contain markdown that is entered as description, so I set my personal instance up to accomodate that by editing line 49 of bookmark_list.html to <div class="markdown">{% markdown bookmark_item.description %}</div>. I understand this isn't a behaviour that would be useful to people using automatically generated descriptions, and it's not a big deal to change manually after any updates, but would markdown descriptions be possible for it to be added as an option that could be toggled in settings?

@sissbruecker
Copy link
Owner

Maybe, though that could result in side-effects when automatically loading descriptions from websites. Those could contain characters that are then interpreted as markdown, or they could contain an HTML tag that the markdown renderer accepts. It's possible to detect whether a description was entered manually or comes from a website, so maybe website descriptions should never be rendered as markdown. Unfortunately that information is lost when exporting an re-importing bookmarks, so that might be harder to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants