Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is types parameter of sinon.spy undocumented feature? #1970

Closed
karak opened this issue Jan 23, 2019 · 2 comments
Closed

Is types parameter of sinon.spy undocumented feature? #1970

karak opened this issue Jan 23, 2019 · 2 comments

Comments

@karak
Copy link

karak commented Jan 23, 2019

Actually, sinon.spy has a special, undocumented parameter called types at third place, and it allows us to observe accessors by passing ["get", "set"].

Is it an official feature to be documented?

Using with TypeScript needs it clear(DefinitelyTyped/DefinitelyTyped#32398).

Thanks.
@mantoni
Copy link
Member

mantoni commented Jan 23, 2019

This feature needs documentation. See #1606.

@karak
Copy link
Author

karak commented Jan 24, 2019

Thank you. I'll close this issue.

@karak karak closed this as completed Jan 24, 2019
@karak karak mentioned this issue Jan 24, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karak @mantoni