Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.4.7 crashes in postinstall #1743

Closed
lerouxb opened this issue Mar 21, 2018 · 11 comments
Closed

4.4.7 crashes in postinstall #1743

lerouxb opened this issue Mar 21, 2018 · 11 comments

Comments

@lerouxb
Copy link

lerouxb commented Mar 21, 2018 

Error: Cannot find module '/blaaaah/node_modules/sinon/scripts/support-sinon.js'
    at Function.Module._resolveFilename (module.js:543:15)
    at Function.Module._load (module.js:470:25)
    at Function.Module.runMain (module.js:690:10)
    at startup (bootstrap_node.js:194:16)
    at bootstrap_node.js:666:3
@bvanderlaan
Copy link

I'm seeing that too

@andrewaustin
Copy link

This started failing for me as well.

@sarunas
Copy link

sarunas commented Mar 21, 2018 •
edited

Same here. No scripts in package.json under files section...

@JanFoerste
Copy link

Same problem here

@singhs020
Copy link

same here

@mroderick
Copy link
Member

I am looking into this

@AmirMaurice
Copy link

Same here for me

@leoner
Copy link

leoner commented Mar 21, 2018

me too.

fengmk2 added a commit to fengmk2/sinon that referenced this issue Mar 21, 2018
@fengmk2
fix: add scripts to files on package.json
83b4f60 
closes sinonjs#1743
@fengmk2 fengmk2 mentioned this issue Mar 21, 2018
Closed
2 tasks
@andnp
Copy link

andnp commented Mar 21, 2018

Yup... I think this is consistent for all users, and I believe @mroderick is looking into it, so we probably don't need any more "me too"'s here. If anything, you can always thumbs up the initial post to reduce comment noise.

@lerouxb
Copy link
Author

lerouxb commented Mar 21, 2018

Thanks for the quick response!

@lerouxb lerouxb closed this as completed Mar 21, 2018
@mroderick
Copy link
Member

I have fixed this in a new release sinon@4.4.8, sorry for the disturbance folks!

wmfgerrit pushed a commit to wikimedia/mediawiki-services-mobileapps that referenced this issue Mar 21, 2018
@mdholloway
Peg sinon to exact version 4.4.6
6761157 
Workaround for sinonjs/sinon#1743.

Otherwise we'll see spurious CI failures, e.g.:

https://integration.wikimedia.org/ci/job/npm-node-6-docker/1368/console
https://integration.wikimedia.org/ci/job/npm-node-6-docker/1369/console

Change-Id: I3b34a282a04c5c451e4f4f184ddb94729095fcba
@ranyitz ranyitz mentioned this issue Mar 21, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add scripts to files on package.json fengmk2/sinon
10 participants
@mroderick @lerouxb @andrewaustin @sarunas @leoner @bvanderlaan @andnp @JanFoerste @AmirMaurice @singhs020