Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support temporal TC39 proposal #335

Open
SimenB opened this issue Sep 7, 2020 · 6 comments
Open

Support temporal TC39 proposal #335

SimenB opened this issue Sep 7, 2020 · 6 comments

Comments

@SimenB
Copy link
Member

SimenB commented Sep 7, 2020

  • FakeTimers version : 6.0.1
  • Environment : N/A
  • Example URL : N/A
  • Other libraries you are using: None

Repo: https://github.com/tc39/proposal-temporal/

We should support faking out usage of all Temporal.now.* methods. Not sure if we need to fake anything else?

Note that I do not think we should support Temporal now - the proposal is still at stage 2. So consider this more of a tracking issue than something that's actionable right now.

What did you expect to happen?
N/A

What actually happens
N/A

How to reproduce
N/A

@benjamingr
Copy link
Member

Cc @littledan I remember you asking for feedback on Temporal.

Is there anything other than .now that sinon would need to fake?

@SimenB
Copy link
Member Author

SimenB commented Mar 11, 2021

It's now stage 3: tc39/proposal-temporal#1440. 🎉 Is this a good time to add support? Along with some docs caveat that it's still unstable (and of course not added to toFake by default). Or should we wait for one engine to land it?

@benjamingr
Copy link
Member

When does it land in Chrome?

@SimenB
Copy link
Member Author

SimenB commented Mar 11, 2021

I have exactly zero clue 😅

@ljharb
Copy link

ljharb commented Mar 11, 2021

It is stage 3, but will not be shipped unflagged at this time, so it'll be awhile.

You will only have to mock out Temporal.now, by design.

I would start implementing now, but perhaps hold off shipping it until at least one engine has landed it, or at least until a production-ready spec-compliant polyfill exists.

@SimenB
Copy link
Member Author

SimenB commented Mar 11, 2021

You will only have to mock out Temporal.now, by design.

Wonderful 👍

I would start implementing now, but perhaps hold off shipping it until at least one engine has landed it, or at least until a production-ready spec-compliant polyfill exists.

If somebody is up for implementing it, I think we can also ship it as long as it's clearly marked as unstable in docs and possibly code, e.g. unstable_enableTemporalSupport: boolean or something. Not sure, and I don't feel strongly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants