Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read only not found in QuillEditorConfigurations #1858

Closed
1 task done
the-best-is-best opened this issue May 12, 2024 · 5 comments
Closed
1 task done

read only not found in QuillEditorConfigurations #1858

the-best-is-best opened this issue May 12, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@the-best-is-best
Copy link

Is there an existing issue for this?

Flutter Quill version

9.3.11

Steps to reproduce

nun

Expected results

nun

Actual results

nun

Code sample

QuillEditor.basic(
configurations: QuillEditorConfigurations(
controller: widget.controller ?? QuillController.basic(),

            readOnly: !widget.edit,
           
            scrollable: true,
            autoFocus: false,
            showCursor: widget.edit,
            expands: false,
            // maxHeight: MediaQuery.of(context).size.height * 0.25,
            padding: EdgeInsets.zero,
            sharedConfigurations: const QuillSharedConfigurations(
              locale: Locale('ar'),
            ),
          ),
        )

Screenshots or Video

No response

Logs

No response

@the-best-is-best the-best-is-best added the bug Something isn't working label May 12, 2024
@hoangsang17th
Copy link
Contributor

hoangsang17th commented May 13, 2024

Update a litte in your code:

QuillEditor.basic(
   configurations: QuillEditorConfigurations(
      controller: widget.controller ?? QuillController(
         readOnly: !widget.edit, // <= Migrate to this
      ),
      scrollable: true,
      autoFocus: false,
      showCursor: widget.edit,
      expands: false,
      // maxHeight: MediaQuery.of(context).size.height * 0.25,
      padding: EdgeInsets.zero,
      sharedConfigurations: const QuillSharedConfigurations(
      locale: Locale('ar'),
   ),
),

@apoleo88
Copy link

It made more sense before, why the (breaking) change?

@hoangsang17th
Copy link
Contributor

It made more sense before, why the (breaking) change?

I don't know :))

@felix-mittermeier
Copy link

This is indeed a breaking change and it's not even mentioned inside the release notes :D

@hoangsang17th
Copy link
Contributor

@the-best-is-best Please mark done for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants