Accept url in config #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Nov 17, 2019
| @@ -13,6 +13,10 @@ test('v4 with impossible timeout', async t => { | |||
| t.false(await isOnline({timeout: 1})); | |||
| }); | |||
|
|
|||
| test('check url', async t => { | |||
| t.true(await isOnline({url: 'https://google.com'})); | |||
There was a problem hiding this comment.
You're not actually testing the url option here as the IP checks are faster. You need to mock those out.
| @@ -5,7 +5,7 @@ const pAny = require('p-any'); | |||
| const pTimeout = require('p-timeout'); | |||
|
|
|||
| const appleCheck = async options => { | |||
| const {body} = await got('http://captive.apple.com/hotspot-detect.html', { | |||
| const {body} = await got(options.url, { | |||
There was a problem hiding this comment.
You cannot just change the URL here. Look at the surrounding code. (https://github.com/sindresorhus/is-online/pull/67/files#diff-168726dbe96b3ce427e7fedce31bb0bcR15)
|
This is not what was agreed on in #61:
|
|
Sorry then, probably have no idea how to do it. Both testing & url config :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61