Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for dark mode on Windows #387

Open
Steveneska opened this issue Aug 15, 2023 · 4 comments
Open

[Feature Request] Add support for dark mode on Windows #387

Steveneska opened this issue Aug 15, 2023 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Steveneska
Copy link

Describe the bug
Not really a bug per se but using Windows 11 in dark mode, I've noticed that while the Simple64 Updater supports dark mode and follows the theme set by the OS, the Simple64 GUI itself does not. I know it's a stretch to ask for such a (trivial) QoL enhancement, but I hope you could consider adding support for dark theme in the emulator itself.

To Reproduce
Steps to reproduce the behavior:

  1. Turn on Windows 11 dark mode.
  2. Open Simple64 GUI and update the emulator.
  3. Once the updater is downloaded, it will open automatically in dark mode following the OS settings.
  4. See error.

Expected behavior
Simple64 GUI should follow the theme settings set in the OS. If using Windows light theme, the emulator and updater should use light theme. And if using Windows dark theme, it should switch to dark theme automatically (or through a setting at the user's choice).

Screenshots
None at this time.

Desktop (please complete the following information):

  • OS: Windows
  • Version: 11 (22H2 Build 22621.2134)
  • GPU: NVIDIA GeForce 3070 Ti Laptop

Additional context
None at this time.

@loganmc10
Copy link
Member

Simple64 uses the Qt6 framework for the GUI. Dark mode works in Linux (with GNOME anyway, it follows the OS theme).

I don't have a windows 11 machine to test with, so this isn't something I would work on, but I'm open to contributions.

@loganmc10 loganmc10 added enhancement New feature or request help wanted Extra attention is needed labels Aug 15, 2023
@loganmc10 loganmc10 changed the title [Feature Request] Add support for dark mode [Feature Request] Add support for dark mode on Windows Aug 15, 2023
@Jj0YzL5nvJ
Copy link

Implementation example: mpv-player/mpv#11473
For caution (Win10 LTSB): mpv-player/mpv#11613

@Squall-Leonhart
Copy link

Those links are only relevant to Win32 theming, which is NOT used by Qt6.

@Steveneska
Copy link
Author

I've looked into the Qt implementation of dark mode in Windows. I can work on a solution to this issue if I have a guide on how to compile Simple64 on Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants