Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_cells_along_line method not robust for tree mesh #346

Open
dccowan opened this issue Dec 22, 2023 · 1 comment · May be fixed by #356
Open

get_cells_along_line method not robust for tree mesh #346

dccowan opened this issue Dec 22, 2023 · 1 comment · May be fixed by #356
Assignees
@dccowan
Labels
bug help wanted TreeMesh QuadTree or OcTree related
Milestone
discretize 1.0

Comments

@dccowan
Copy link
Member

dccowan commented Dec 22, 2023

Summary

When the get_cells_along_line is called for a tree mesh, sometimes it will cause the kernel to crash. This seems to happen when a line segment is defined diagonally from one node to another, or one parallel edge to another. This has raised practical challenges in EM modeling with SimPEG. I have attached files to reproduce the error directly with discretize, and for a TDEM simulation in SimPEG. The get_cells_along_line method is defined in discretize/_extensions/tree_ext.pyx.

test_files.zip

For this issue to be fixed, the scripts should run correctly without failing for both values of the variable 'height' specified.
@dccowan dccowan added bug help wanted TreeMesh QuadTree or OcTree related labels Dec 22, 2023
@dccowan dccowan added this to the discretize 1.0 milestone Dec 22, 2023
@dccowan dccowan self-assigned this Dec 22, 2023
@dccowan
Copy link
Member Author

dccowan commented Jan 3, 2024

image
Unhappy cases

@jcapriot jcapriot linked a pull request Apr 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dccowan dccowan

Labels
bug help wanted TreeMesh QuadTree or OcTree related
Projects
None yet
Milestone
discretize 1.0
Development

Successfully merging a pull request may close this issue.

Expose TreeMesh geometric intersections used for refine functions. jcapriot/discretize
1 participant
@dccowan