Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasette-desktop 0.2.1 (new formula) #115074

Merged
merged 7 commits into from
Nov 30, 2021
Merged

datasette-desktop 0.2.1 (new formula) #115074

merged 7 commits into from
Nov 30, 2021

Conversation

drewda
Copy link
Contributor

@drewda drewda commented Nov 29, 2021

A macOS GUI application powered by the datasette library

closes simonw/datasette-app#128

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@drewda
Copy link
Contributor Author

drewda commented Nov 29, 2021

I have addressed all the audit issues with the exception of:

audit for datasette-desktop: failed
 - cask token mentions desktop
 - GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
Error: 2 problems in 1 cask detected

I believe the first issue is not relevant, since this application is called "Datasette Desktop" on its marketing page. It is also meant to differentiate from https://github.com/Homebrew/homebrew-core/blob/master/Formula/datasette.rb

Re the second issue, this particular repo doesn't meet the popularity threshold. But the overall Datasette project (led by the same maintainer, @simonw) is very popular. Can a homebrew moderator advise on if this is sufficient? Thank you.

@drewda drewda marked this pull request as ready for review November 29, 2021 22:27
@bevanjkay
Copy link
Member

Thank you for your contribution @drewda
Please try to add a zap stanza. The linked documentation provides some recommended methods to create it.

@bevanjkay bevanjkay added the awaiting user reply Issue needs response from a user. label Nov 29, 2021
@drewda
Copy link
Contributor Author

drewda commented Nov 30, 2021

Thanks for reviewing, @bevanjkay. I've added a zap stanza. If there are any other changes that are worth making, feel free to let me know any time.

@bevanjkay bevanjkay added awaiting maintainer feedback Issue needs response from a maintainer. and removed awaiting user reply Issue needs response from a user. labels Nov 30, 2021
@bevanjkay
Copy link
Member

I believe the first issue is not relevant, since this application is called "Datasette Desktop" on its marketing page. It is also meant to differentiate from https://github.com/Homebrew/homebrew-core/blob/master/Formula/datasette.rb

@drewda I have renamed the cask to datasette - the above is not seen as a valid reason to provide an exemption to the token rules. An example of a popular cask/formula with the same situation is docker.

@bevanjkay
Copy link
Member

/rebase

@miccal
Copy link
Member

miccal commented Nov 30, 2021

Thank you @drewda.

@miccal miccal merged commit 180ec77 into Homebrew:master Nov 30, 2021
@miccal miccal removed the awaiting maintainer feedback Issue needs response from a maintainer. label Nov 30, 2021
@drewda
Copy link
Contributor Author

drewda commented Nov 30, 2021

Thank you, @bevanjkay and @miccal!

@drewda drewda deleted the datasette-desktop branch November 30, 2021 05:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create brew install --cask datasette-app for macOS
4 participants