Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle CSV columns with square braces #121

Open
simonw opened this issue Sep 15, 2021 · 3 comments
Open

Handle CSV columns with square braces #121

simonw opened this issue Sep 15, 2021 · 3 comments
Labels
bug Something isn't working custom-datasette Need to customize Datasette itself (custom templates, CSS, JS etc) requested-feature

Comments

@simonw
Copy link
Owner

simonw commented Sep 15, 2021

https://twitter.com/victorianoi/status/1438073122817810435

kudos the desktop app! Unfortunately, I have plenty of CSVs with columns using [] brackets for serializing arrays :/

58FA0B5B-98FC-4748-87DA-8AD71EC3270E
@simonw simonw added bug Something isn't working custom-datasette Need to customize Datasette itself (custom templates, CSS, JS etc) requested-feature labels Sep 15, 2021
@simonw
Copy link
Owner Author

simonw commented Sep 23, 2021

This is actually an error from sqlite-utils due to this issue:

@simonw
Copy link
Owner Author

simonw commented Sep 23, 2021

Oh wow, the bug I filed in Python about this has since been fixed! https://bugs.python.org/issue39652

@simonw
Copy link
Owner Author

simonw commented Sep 23, 2021

I think it's best to still keep [ and ] out of column names though. Transforming them into ( and ) seems reasonable - but should that happen here or in sqlite-utils? I think in sqlite-utils.

@simonw simonw mentioned this issue Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working custom-datasette Need to customize Datasette itself (custom templates, CSS, JS etc) requested-feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw