Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache then network support #13

Open
simonfl3tcher opened this issue Feb 25, 2017 · 5 comments
Open

Cache then network support #13

simonfl3tcher opened this issue Feb 25, 2017 · 5 comments

Comments

@simonfl3tcher
Copy link
Owner

It would be good to add support for the cache then network approach. At the moment this is completely unsupported. The repository uses the offline-plugin for webpack. In an ideal world we would carry on using this as it is built for this specific problem.

The approach is open for discussion.

@jasan-s
Copy link

jasan-s commented Feb 26, 2017

If I may ask why offline-plugin over say sw-precache?

@simonfl3tcher
Copy link
Owner Author

@jasan-s I chose offline-plugin as it worked well with webpack out of the box, the main aim of this app was to provide a quick and simple way to create a PWA with React. However, if we feel that sw-precache is a better option moving forward, I am more than happy to consider it. Let me know what your thoughts are.

@jasan-s
Copy link

jasan-s commented Feb 26, 2017

I personally have not used this offline-plugin, thus i was curious. But it does seem like its quite easy to setup. I use sw-precache-webpack-plugin. Does the plugin provide runtime caching of url patterns fetched over network? or just the external local files not available during build.

@jasan-s
Copy link

jasan-s commented Feb 26, 2017

Since I have vendor common chunk(react, react dom), I use MD5 hash to limit SW Update to just the app chunks.

@simonfl3tcher
Copy link
Owner Author

Does the plugin provide runtime caching of url patterns fetched over network?

I am not sure sure to be honest, something we need to look into, feels like something it would support though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants