Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

Blink threshold is hardcoded #24

Open
cfculhane opened this issue Jul 19, 2020 · 2 comments
Open

Blink threshold is hardcoded #24

cfculhane opened this issue Jul 19, 2020 · 2 comments

Comments

@cfculhane
Copy link
Contributor

Currently the blink threshold is hardcoded inside the engine.Engine class, ideally this should be a param passed in so an external user can adjust it. Alternatively, a method could be written to take in an expected number of blinks, and adjust the blink threshold to match the expected number (so you could run through a small sample of video on the same subject to attain the threshold, then set that threshold to process the rest of the dataset)

@simonarvin
Copy link
Owner

I think adjusting the threshold to a small video sample could work. Often, contrasts, facial appearance etc. have an effect on how blinks affect the (mono)chromatic distribution. In mice, blinking causes a less pronounced shift in mean/std than in human (based on my trials). Both are very distinct, however.

As you suggest, we should make the param user adjustable too.

@cfculhane
Copy link
Contributor Author

Yeah, I'll have a tinker. Supplying the parameters would be an easy first step, but writing some sort of interactive tuning model would be a bit trickier, as the user would have to supply information about an expected number of blinks, and time stamps.

Thinking a bit more, a simpler input could be to have a separate blink video to test against, supplied by the user, which then generates an updated parameter file that could be used against further application runs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants