Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Furigana of phrases don't get updated #226

Open
franzmondlichtmann opened this issue Apr 28, 2024 · 1 comment
Open

Furigana of phrases don't get updated #226

franzmondlichtmann opened this issue Apr 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@franzmondlichtmann
Copy link

franzmondlichtmann commented Apr 28, 2024

When I save both words of a two-word phrase and also save the phrase, the furigana shows up.
When I now change the reading of the phrase to がくしゅうしゃ, the furigana don't get updated for the phrase.
がくしゅうしゃ means learner.
がくしゅうしゃ consists of がくしゅう and しゃ, in this combination. Standing alone the pronunciation is がくしゅう and もの. But together the pronunciation changes dramatically.

Linguacafe v0.11.2, using Firefox on Archlinux

@franzmondlichtmann franzmondlichtmann changed the title Furigana of a phrase don't get updated Furigana of phrases don't get updated Apr 28, 2024
@simjanos-dev
Copy link
Owner

simjanos-dev commented Apr 28, 2024

Oh. I haven't even thought about that possibility. Thank you for the bug report!

Unfortunately, I don't think that's possible to fix currently, because I do not treat phrases as a different html element. This is the reason why phrases also get separated at the end of a line it if happens to be displayed there.

I will have to significantly rewrite the interactive text part to fix this, it won't be fixed nowadays. I think the best I can do is hide the furigana on pharses temporarily to avoid confusion about this.

@simjanos-dev simjanos-dev added the bug Something isn't working label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants