Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel code quality improvements. #103

Open
10 of 23 tasks
simjanos-dev opened this issue Feb 4, 2024 · 0 comments
Open
10 of 23 tasks

Laravel code quality improvements. #103

simjanos-dev opened this issue Feb 4, 2024 · 0 comments
Labels
code changes Code changes that do not have a functional impact, but improve it in some way. no pull requests I want to work on this Issue personally. Please do not send pull requests.

Comments

@simjanos-dev
Copy link
Owner

simjanos-dev commented Feb 4, 2024

This is a long list of tasks to improve the code quality. I will probably implement them throughout multiple updates.

Tasks:

  • Replace the TextBlock model with a TextBlock service
  • Move Goal related logic to a new GoalService class (look inside word and phrase model setStage functions)
  • Laravel 11 and PHP 8.3 Update
  • Rename "base_word" to "lemma" Rename "base_word" to "lemma". #99
  • Rename lessons to chapters Rename lessons to chapters in the code #20
  • Rename stage to level
  • Try and catch blocks should be moved from app/Services/AnkiApiService.php to app/Http/Controllers/AnkiController.php.
  • After LinguaCafe has been updated to Laravel 11, GetSubtitleFileContentRequest validation should also check the subtitle file's extension.

Rename media player:

  • Rename MediaPLayerController to JellyfinController
  • Rename MediaPlayerCache model and database to JellyfinSubtitleCache

Moving business logic from controllers to service classes and DB logic into models,
replacing return values with proper HTTP responses,
and creating request classes and writing proper validations:

  • AnkiController
  • BookController
  • ChapterController
  • DictionaryController
  • GoalController
  • HomeController
  • ImageController
  • ImportController
  • MediaPlayerController
  • ReviewController
  • SettingsController
  • UserController
  • VocabularyController
@simjanos-dev simjanos-dev added the code changes Code changes that do not have a functional impact, but improve it in some way. label Feb 4, 2024
@simjanos-dev simjanos-dev pinned this issue Feb 4, 2024
@simjanos-dev simjanos-dev added the no pull requests I want to work on this Issue personally. Please do not send pull requests. label Feb 8, 2024
simjanos-dev added a commit that referenced this issue Feb 18, 2024
simjanos-dev added a commit that referenced this issue Feb 18, 2024
simjanos-dev added a commit that referenced this issue Feb 22, 2024
simjanos-dev added a commit that referenced this issue Feb 23, 2024
simjanos-dev added a commit that referenced this issue Feb 23, 2024
simjanos-dev added a commit that referenced this issue Feb 24, 2024
simjanos-dev added a commit that referenced this issue Feb 27, 2024
simjanos-dev added a commit that referenced this issue Feb 28, 2024
simjanos-dev added a commit that referenced this issue Feb 28, 2024
simjanos-dev added a commit that referenced this issue Mar 1, 2024
simjanos-dev added a commit that referenced this issue Mar 1, 2024
simjanos-dev added a commit that referenced this issue Mar 2, 2024
simjanos-dev added a commit that referenced this issue Mar 2, 2024
simjanos-dev added a commit that referenced this issue Mar 2, 2024
simjanos-dev added a commit that referenced this issue Mar 3, 2024
simjanos-dev added a commit that referenced this issue Mar 3, 2024
simjanos-dev added a commit that referenced this issue Mar 3, 2024
simjanos-dev added a commit that referenced this issue Mar 3, 2024
simjanos-dev added a commit that referenced this issue Mar 3, 2024
simjanos-dev added a commit that referenced this issue Mar 3, 2024
simjanos-dev added a commit that referenced this issue Mar 3, 2024
simjanos-dev added a commit that referenced this issue Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code changes Code changes that do not have a functional impact, but improve it in some way. no pull requests I want to work on this Issue personally. Please do not send pull requests.
Projects
None yet
Development

No branches or pull requests

1 participant