New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel code quality improvements. #103
Labels
code changes
Code changes that do not have a functional impact, but improve it in some way.
no pull requests
I want to work on this Issue personally. Please do not send pull requests.
Comments
simjanos-dev
added
the
code changes
Code changes that do not have a functional impact, but improve it in some way.
label
Feb 4, 2024
This was referenced Feb 7, 2024
simjanos-dev
added
the
no pull requests
I want to work on this Issue personally. Please do not send pull requests.
label
Feb 8, 2024
simjanos-dev
added a commit
that referenced
this issue
Feb 18, 2024
simjanos-dev
added a commit
that referenced
this issue
Feb 18, 2024
simjanos-dev
added a commit
that referenced
this issue
Feb 22, 2024
simjanos-dev
added a commit
that referenced
this issue
Feb 23, 2024
simjanos-dev
added a commit
that referenced
this issue
Feb 23, 2024
simjanos-dev
added a commit
that referenced
this issue
Feb 24, 2024
simjanos-dev
added a commit
that referenced
this issue
Feb 27, 2024
simjanos-dev
added a commit
that referenced
this issue
Feb 28, 2024
simjanos-dev
added a commit
that referenced
this issue
Feb 28, 2024
simjanos-dev
added a commit
that referenced
this issue
Feb 29, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 1, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 1, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 2, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 2, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 2, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 3, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 3, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 3, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 3, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 3, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 3, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 3, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 4, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 4, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 7, 2024
simjanos-dev
added a commit
that referenced
this issue
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code changes
Code changes that do not have a functional impact, but improve it in some way.
no pull requests
I want to work on this Issue personally. Please do not send pull requests.
This is a long list of tasks to improve the code quality. I will probably implement them throughout multiple updates.
Tasks:
app/Services/AnkiApiService.php
toapp/Http/Controllers/AnkiController.php
.Rename media player:
Moving business logic from controllers to service classes and DB logic into models,
replacing return values with proper HTTP responses,
and creating request classes and writing proper validations:
The text was updated successfully, but these errors were encountered: