Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for polymorphic has_one to eager loading #11203

Closed
4 tasks done
beerbohmdo opened this issue Apr 19, 2024 · 1 comment
Closed
4 tasks done

Add support for polymorphic has_one to eager loading #11203

beerbohmdo opened this issue Apr 19, 2024 · 1 comment
Assignees
@GuySartorelli
Labels
affects/v5 impact/medium type/bug

Comments

@beerbohmdo
Copy link
Contributor

beerbohmdo commented Apr 19, 2024 •
edited by GuySartorelli

Description

Polymorphic has_one relations are currently not supported by eager-loading it just throws an error that DataObject is not a valid data class.

Additional context or points of discussion

No response

Validations

  • You intend to implement the feature yourself
  • You have read the contributing guide
  • You strongly believe this feature should be in core, rather than being its own community module
  • You have checked for existing issues or pull requests related to this feature (and didn't find any)

PRs
@beerbohmdo beerbohmdo mentioned this issue Apr 19, 2024
Merged
8 tasks
@GuySartorelli GuySartorelli self-assigned this Apr 21, 2024
beerbohmdo added a commit to beerbohmdo/silverstripe-framework that referenced this issue Apr 24, 2024
@beerbohmdo
ENH Add polymorphic has_one support to eager loading silverstripe#11203
7e49952
beerbohmdo added a commit to beerbohmdo/silverstripe-framework that referenced this issue May 7, 2024
@beerbohmdo
ENH Add polymorphic has_one support to eager loading silverstripe#11203
77c9cb4
@GuySartorelli
Copy link
Member

PR merged. This will be automatically tagged by GitHub actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
affects/v5 impact/medium type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beerbohmdo @GuySartorelli