GridField breadcrumbs may use incorrect casting for titles

[kinglozzer]

Module version(s) affected

5.0.0+

Description

Tentatively filing this as a bug... it could be argued it’s a feature request too, I think it’s somewhere in between.

I’m working on a module that’ll allow very basic “rich text editing” for titles (i.e. Markdown-based instead of TinyMCE). Part of that is using a custom DBField type for storing the title and controlling how it’s rendered. I can control how it’s rendered everywhere inside and outside of the CMS, except the GridField breadcrumb:

This is because it accesses the property directly, which means it falls back to using the default casting (which is DBText):

silverstripe-framework/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php

Line 919 in 5ab9ded

$title = ($this->record->Title) ? $this->record->Title : "#{$this->record->ID}";

I’d like to propose changing this to $this->record->obj('Title') instead, so that if the database type for Title is changed to something other than DBVarchar, it uses the correct casting instead of always using DBText::forTemplate().

How to reproduce

Override title field type for an item that can be edited in a GridField (e.g. I’m using non-inline-editable elements):

DNADesign\Elemental\Models\BaseElement:
  db:
    Title: MyCustomDBField

class MyCustomDBField extends DBVarchar
{
    public function forTemplate()
    {
        return 'TEST';
    }
}

'TEST' should appear in the GridField breadcrumb, but doesn't.

Possible Solution

No response

Additional Context

No response

Validations

• Check that there isn't already an issue that reports the same bug
• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

PRs

• FIX: Ensure GridField breadcrumbs use correct casting class (fixes #11174) #11175