Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the BackLinks relation in SiteTree to a polymorphic many_many relation #2895

Open
sabina-talipova opened this issue Oct 11, 2023 · 0 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 11, 2023

Description

In SiteTree, the BackLinks relationship should be turned into a polymorphic many_many relationship (using a many_many through relation as documented).

SiteTree::BackLinksTracking() would then be redundant - you'd just get the backlinks directly from the polymorphic relation.

See:

// @todo - Implement PolymorphicManyManyList to replace this
$list = ArrayList::create();

Related

@GuySartorelli GuySartorelli changed the title TODO: SiteTree::BackLinkTracking(). Logic using ArrayList should be replaced with PolymorphicManyManyList Change the BackLinks relation in SiteTree to a polymorphic many_many relation Oct 20, 2023
@GuySartorelli GuySartorelli added this to the Silverstripe CMS 6 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants