FolderNameFilter needs multiple calls in order to fully filter certain patterns

[sb-relaxt-at]

Tested using silverstripe/assets v1.6.1:

$folderFilter = new SilverStripe\Assets\FolderNameFilter();
$folderFilter->filter('foo.-bar'); // foo--bar
$folderFilter->filter('foo--bar'); // foo-bar

I assume this is due to the merge order of the replacement pattern config. From my point of view it would be better to perform replacements until the name is stable as there might be complex dependencies between patterns that require multiple passes. Something like this should work in FileNameFilter#filter:

$nameBefore = null;
while($nameBefore !== $name) {
    $nameBefore = $name;
    foreach ($this->getReplacements() as $regex => $replace) {
        $name = preg_replace($regex, $replace, $name);
    }
}

[emteknetnz]

Related #419

Would you like to raise a PR to fix this?

[sb-relaxt-at]

I finally prepared a PR. Which branch should I create the pull request against?

[michalkleiner]

1.12 @sb-relaxt-at, thanks!