Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection timeout #10

Open
marcbrevoort-cyberhive opened this issue Feb 15, 2024 · 1 comment
Open

Connection timeout #10

marcbrevoort-cyberhive opened this issue Feb 15, 2024 · 1 comment

Comments

@marcbrevoort-cyberhive
Copy link
Contributor

There's a connection timeout when using rusturn against a standard turn server.
I think this is due to two things.

  1. create_permission does not allow setting a permission when one already exists for a given client. Thus when we want to refresh a permission, the previous one first needs to be expired completely (causing a gap in communications) By dropping the check for existing permissions, create_permission can be called again even if the permission hasn't expired yet, resulting in a refreshed permission on the server side.

  2. timeouts seem to be coded backwards. For instance refresh for allocations times out at 10/9 the lifetime rather than at 9/10 the lifetime. This is probably the main issue.

@sile
Copy link
Owner

sile commented Feb 15, 2024

Thank you for reporting this issue.
Unfortunately, I am unable to address it at this time, as the priority of rusturn development is very low.
If you could create a pull request to fix the timeout problem, I will review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants