Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ed25519ph signer/verifier #1594

Closed
ret2libc opened this issue Jan 11, 2024 · 1 comment · Fixed by #1595
Closed

Add support for ed25519ph signer/verifier #1594

ret2libc opened this issue Jan 11, 2024 · 1 comment · Fixed by #1595
Labels
enhancement New feature or request

Comments

@ret2libc
Copy link
Contributor

Description

At Trail of Bits, we're looking at implementing part of the Configurable Crypto Algorithms proposal (specifically Phase 1). See sigstore/cosign#3271, sigstore/rekor#1724, sigstore/fulcio#1388 for related issues in the other repos.

We started doing some work with sigstore/fulcio#1517, which tries to support only client keys of type ecdsa+sha256 and ed25519. Fulcio does not really care about the user keys, however Rekor does and right now it does not support ed25519 (see sigstore/rekor#1724 for details).

As suggested there and in other rekor issues, the idea is to add support for ed25519ph which is a pre-hashed version of ed25519. Having this support in sigstore/sigstore would allow sigstore-go, rekor, and cosign to use ed25519 keys as an alternative to the default ecdsa + sha256.

cc @tetsuo-cpp @woodruffw

@ret2libc
Copy link
Contributor Author

Fulcio does not really care about the user keys, however Rekor does and right now it does not support ed25519 (see sigstore/rekor#1724 for details).

Actually, also Fulcio does need the updated sigstore/sigstore because the ProofOfPossession check (https://github.com/sigstore/fulcio/blob/main/pkg/server/grpc_server.go#L132) loads the SignerVerifier (in https://github.com/sigstore/fulcio/blob/main/pkg/challenges/challenges.go#L46) and it needs to use the Ed25519ph version in order to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant